-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some formatting options #67
base: master
Are you sure you want to change the base?
Conversation
Hey, thanks for your contribution. Are you aware of the new openxlsx2 package by @JanMarvin? It seems to have a lot of formatting functionality built-in: https://janmarvin.r-universe.dev/openxlsx2/doc/manual.html The vignettes are also very extensive: https://janmarvin.r-universe.dev/openxlsx2 In what way would we benefit from duplicating this functionality in writexl? |
It's totally up to you. :) I just prefer to use writexl as it is fast and works well. I just wanted those convenience options to the result. I can't install openxlsx2 from Bioconductor or CRAN so I have not been testing openxlsx2 (not available for 4.3.1 on windows) but I can see that this has a lot of functionality. |
If we had done it first in |
exactly, I only used the options that the current bundled version of libxlsxwriter provides |
I tried to address simple issues from #4 the first commit is only simple stuff but I forgot to change the parameter count
{"C_write_data_frame_list", (DL_FUNC) &C_write_data_frame_list, 5},
I totally understand If this would be rejected as you stated that this might make the code harder to maintain.